Add posibility to use Bearer Token for auth #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zunkree
force-pushed
the
zunkree/k8s-authz
branch
from
c78352e
to
05a785d
Compare
zunkree
force-pushed
the
zunkree/k8s-authz
branch
from
05a785d
to
c4a7a6c
Compare
nickmintel
reviewed
Dec 31, 2018
| @@ -12,8 +12,7 @@ h3 { font-size: 16px; } | |||
| pre { | |||
| background-color: #eff0f1; | |||
| padding: 5px; | |||
| white-space: pre-wrap; | |||
| overflow-wrap: break-word; | |||
| overflow: auto; | |||
There was a problem hiding this comment.
Could we revert the CSS change - overflow:auto causes a horizontal scrollbar which we would rather avoid.
nickmintel
reviewed
Dec 31, 2018
| @@ -64,13 +64,14 @@ type Cluster struct { | |||
| K8s_Master_URI string | |||
| K8s_Ca_URI string | |||
| K8s_Ca_Pem string | |||
| Bearer_Token bool | |||
There was a problem hiding this comment.
Could we rename this to Use_Bearer_Token to make it a bit clearer?
|
@zunkree thanks for this - could you give some info on the use-case for this (I might add to the documentation when this would be useful). I'm guessing the api-server is not configured for oidc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.